Rename SystemIPs to NetworkIdentifiers for HTTPBootConfig #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
api-change
documentation
hardikdr
force-pushed
the
enh/add-systemids
branch
2 times, most recently
from
43633d5 to
119d5fe
Compare
hardikdr
force-pushed
the
enh/add-systemids
branch
from
119d5fe to
83cb9cd
Compare
defo89
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Renaming SystemIPs to NetworkIdentifiers, as SystemIPs are populated also with MACs.
Adapting the NIC.IP in the tests to use the pointer which is the new API change inside the Metal-operator.
Fixes #